[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2454 - trunk/subversion/libsvn_wc

From: Justin Erenkrantz <jerenkrantz_at_apache.org>
Date: 2002-07-10 17:52:17 CEST

On Wed, Jul 10, 2002 at 10:36:40AM -0500, kfogel@tigris.org wrote:
> Author: kfogel
> Date: Wed, 10 Jul 2002 10:36:37 -0500
> New Revision: 2454
>
> Modified:
> trunk/subversion/libsvn_wc/diff.c
> Log:
> Following up to revision 2449:
>
> * subversion/libsvn_wc/diff.c
> (file_diff): Take a pool argument.
> (directory_elements_diff): Use a true iteration pool, passing it
> directly to file_diff, instead of shadowing the dir_baton's pool.

Ah, I wasn't sure if/when we could modify the function parameters.
Thanks for cleaning up my mess.

BTW, I think the svn_path_join (?) in directory_elements_diff should
be allocated from the subpool not dir_baton->pool. -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 10 17:52:47 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.