Re: svn commit: rev 2450 - trunk/subversion/libsvn_wc

On Wed, Jul 10, 2002 at 04:29:22AM -0500, jerenkrantz@tigris.org wrote:
> Author: jerenkrantz
> Date: Wed, 10 Jul 2002 04:29:04 -0500
> New Revision: 2450
>
> Modified:
> trunk/subversion/libsvn_wc/props.c
> Log:
> * subversion/libsvn_wc/props.c
> (svn_wc__load_prop_file): Open the propfile with APR_BUFFERED so that the
> single-character reads in svn_io_read_length_line do not result in
> numerous system calls.

Previously, we were doing the following via svn_hash_read():

read(3, "E", 1) = 1
read(3, "N", 1) = 1
read(3, "D", 1) = 1
read(3, "\n", 1) = 1
...

This takes advantage of APR's buffering feature so that we now do:

read(3, "END\n", 4096) = 4

This should make reading the property files a bit faster since we'll
avoid the multiple read() calls. All I can say is 'ouch!' -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 10 11:45:11 2002