[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2428 - trunk/subversion/include trunk/subversion/libsvn_fs trunk/subversion/libsvn_wc trunk/subversion/libsvn_subr trunk/subversion/libsvn_client

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2002-07-08 18:20:38 CEST

kfogel@tigris.org writes:

> Author: kfogel
> Date: Mon, 08 Jul 2002 01:18:58 -0500
> New Revision: 2428
> Modified:
> trunk/subversion/include/svn_fs.h
> trunk/subversion/include/svn_io.h
> trunk/subversion/libsvn_client/add.c
> trunk/subversion/libsvn_client/auth.c
> trunk/subversion/libsvn_client/client.h
> trunk/subversion/libsvn_client/commit.c
> trunk/subversion/libsvn_client/commit_util.c
> trunk/subversion/libsvn_client/copy.c
> trunk/subversion/libsvn_client/repos_diff.c
> trunk/subversion/libsvn_fs/fs.c
> trunk/subversion/libsvn_subr/io.c
> trunk/subversion/libsvn_subr/svn_error.c
> trunk/subversion/libsvn_subr/target.c
> trunk/subversion/libsvn_wc/props.c
> Log:
> Continuing work on issue #494.
> Apply the remainder of Marcus Comstedt's `svn_utf_2366_libs.patch',
> with some tweaks. This is the "separate commit" referred to in
> revision 2424. Marcus -- and anyone else -- please review :-).
> Note that this leaves the code in a technically broken state until his
> svn_utf_2366_client.patch is applied, which I'll do in an upcoming
> commit. That patch makes the command line client ensure that it's
> passing UTF-8 paths down into the libraries, which are now expecting
> that encoding.
> It's only "technically" broken because in practice everything works
> fine, and make check still passes, as long as you use ascii filenames
> and/or don't pass the `--enable-utf8' flag to configure.

Looks like it's "really" broken :-(

I'm seeing lots of failures in the regression tests when configured
without --enable-utf8. Recompiling only utf.c with -DSVN_UTF8 (as
well as relinking) appears to solve the problem. So, although this
patch introduced the failures, I suspect utf.c rather than the files
changed here.

The first test that fails is basic_tests.py number 4.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 8 18:21:08 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.