Daniele Nicolodi wrote:
>
> On Sun, Jul 07, 2002 at 02:07:37PM -0400, Benjamin Reed wrote:
> > Daniele Nicolodi [daniele@grinta.net] wrote:
> > > I agree on that. Is completely unusefull have a complex script when
> > > the 90% of users don't use his fancy features. If the author of
> > > commi-email.pl is too busy i can do that splitting.
> >
> > Another possibility is to demand-load perl modules, and make the "fancy"
> > options optional. If written properly, the commit script could check for
> > those extra modules it wants at runtime, and disable functionality if it's
> > not there. You can do something like:
>
> I vote for write a simplified version of commit-email.pl also because a
> small script i more simply customizable and readable by users. I think
> that the function of this script is also to be an example of how a commit
> hook script could be writed and to be a base for write more case specific
> scripts.
This isn't that hard. We only need one copy of commit-email.pl. I'll
pull out Storable and also skip Data::Dumper. I simple ~10 line subroutine
will replace the functionality I wanted.
The original intent of using Storable was to make a copy of the hash
that contains the information for each project defined from the command
line. Given that errors may arise from later modifications to the
script to add additional hash elements for additional functionality, I
thought it would be best to make a clone of the hash using a standard
method instead of having to initialize the hash twice in two different
places in the script (much less error prone).
In any case, expect a patch later today or tomorrow to take out
Storable.
Best,
Blair
--
Blair Zajac <blair@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jul 7 20:41:12 2002