Re: Mild bug?

Philip Martin <philip@codematters.co.uk> writes:

> svn *does* trap the aborted diff process, that's why you see the error
> message. Did you mean ignore the aborted diff process and try to
> carry on? Ignoring a failed diff would be the wrong thing to do.

Agreed.

> Did you mean detect that diff has exited with SIGPIPE? APR doesn't
> appear to allow us to determine which signal was received.

!!

> Even if we could detect it svn still has to exit.

Why? So the child died with SIGPIPE, big deal. Why not allow svn to
ignore the death, continue on, and just eventually exit with no error?

> I suppose we could omit the error message but I'm not sure it's an
> improvement.

That would definitely be a user-interface improvement. The user
simply terminated the 'more' process... why should an error come up in
the user's face? I pipe things into 'more' all the time, and hit 'q'
to exit. I've never seen the original data-producing program yell at
me about that.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 3 22:45:34 2002