[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2406 - trunk/subversion/libsvn_ra_dav

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-07-03 16:45:29 CEST

striker@tigris.org writes:
> * subversion/libsvn_ra_dav/commit.c
> (commit_add_dir, commit_add_file): escape the uri before passing it to
> neon. This fixes adding with history for dirs/files that contain
> spaces.

Ummm. Hmmm. Sander, have you read over all of



The quick summary is: we're not going to do URI escaping inside the
svn libraries. Instead, the libraries are going to accept pre-escaped
URIs, and it's up to the client itself (the user client, I mean, not
libsvn_client) to make sure the URI is escaped without having lost any

Whether the client does this by insisting that the user type "%20"
instead of " ", or by escaping spaces itself, is outside the scope of
issue #494, and is the topic of another thread, so I won't go into it
here. But either way, libsvn_ra_dav should not be performing any
escaping internally.

Yes, this implies that we will also be storing URIs in escaped form,
for example in the entries file.

So, I think this change needs to come out. The real fix happens at a
higher layer, and I'm working on issue #494 right now, so you should
see it soon.

I'm not reverting just yet, want to get your (and others') thoughts


> Modified: trunk/subversion/libsvn_ra_dav/commit.c
> ==============================================================================
> --- trunk/subversion/libsvn_ra_dav/commit.c (original)
> +++ trunk/subversion/libsvn_ra_dav/commit.c Wed Jul 3 09:02:24 2002
> @@ -746,6 +746,7 @@
> header given to COPY is simply the wr_url that is already
> part of the child object. */
> copy_src = svn_path_join(bc_url.data, bc_relative.data, dir_pool);
> + copy_src = svn_path_uri_encode(copy_src, dir_pool);
> /* Have neon do the COPY. */
> status = ne_copy(parent->cc->ras->sess,
> @@ -933,6 +934,7 @@
> header given to COPY is simply the wr_url that is already
> part of the file_baton. */
> copy_src = svn_path_join(bc_url.data, bc_relative.data, file_pool);
> + copy_src = svn_path_uri_encode(copy_src, file_pool);
> /* Have neon do the COPY. */
> status = ne_copy(parent->cc->ras->sess,
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 3 16:55:05 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.