[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: proposal to add apr_check_dir_empty() to APR

From: Justin Erenkrantz <jerenkrantz_at_apache.org>
Date: 2002-07-02 23:31:05 CEST

On Tue, Jul 02, 2002 at 02:15:16PM -0700, Ryan Bloom wrote:
> which it isn't. 2) APR_EGENERAL doesn't really mean anything and
> should never have been added to the code. There is no such thing as a

APR_EGENERAL is probably used where an APR_FAILURE would work much
better. In fact, I really like that idea. In a lot of functions,
it is possible to either return an apr status code, success, or just
plain failure where it doesn't make sense to create yet another error
code for one function (esp. when that function isn't within APR).

IMHO, APR_TRUE and APR_FALSE are really bad ideas...

And, I think APR_EEXIST makes the most sense for
apr_dir_check_empty(). -- justin

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 2 23:31:32 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.