Re: proposal to add apr_check_dir_empty() to APR

"Ryan Bloom" <rbb@covalent.net> writes:
> This isn't portable. POSIX specifically states that you don't need to
> return "." or "..", and APR doesn't make any comments about them.

Actually, APR does promise that "." and ".." will be returned, and
will be returned first, on all platforms.

See apr/include/apr_file_info.h:

   /**
    * Read the next entry from the specified directory.
    * @param finfo the file info structure and filled in by apr_dir_read
    * @param wanted The desired apr_finfo_t fields, as a bit flag of \
      APR_FINFO_ values
    * @param thedir the directory descriptor returned from apr_dir_open
    * @remark All systems return . and .. as the first two files.
    */
   APR_DECLARE(apr_status_t) apr_dir_read(apr_finfo_t *finfo,

> The return code should not be EGENERAL if the directory isn't empty.
> Create a new status code if you have to, but a non-empty directory is
> not an error condition.

Agreed, can make up a better status code for this.

> If you fix those two problems, then I am all for this going into APR.
> However, can we get better performance on some platforms by using native
> functions???

I don't know. Anyone know?

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 2 22:18:21 2002