[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: out of date comment in libsvn_wc/update_editor.c?

From: <cmpilato_at_collab.net>
Date: 2002-07-02 18:12:21 CEST

Karl Fogel <kfogel@newton.ch.collab.net> writes:

> Garrett Rooney <rooneg@electricjellyfish.net> writes:
> > so i just noticed a coment in libsvn_wc/update_editor.c that looks
> > like it might be out of date:
> >
> > /* Gets set iff this directory has a "disjoint url", i.e. its URL is
> > not its [parent's URL + name].
> >
> > ### NOTE: this editor is now detecting disjoint files and
> > subtrees, but is not yet *using* this information. It will when
> > we finish issue #575.
> > */
> > svn_boolean_t disjoint_url;
> >
> > is this still valid? issue #575 has been resolved for a while,
> > afaik...
> Yes, this code is rather odd. #575 claims to be resolved, but all
> occurrences of `disjoint_url' in update_editor.c are clearly without
> effect. This makes me wonder if 575 was resolved by other means (the
> new commit system), and all this disjoint_url stuff in update_editor.c
> is irrelevant.
> Mike, Ben? Just search for "disjoint_url", see if it's relevant any
> more. It's certainly not doing anything now; I just can't tell if
> there's anything planned for it...

I can't really think of a good reason for variable remaining. The job
of determining disjointness is/will-continue-to-be handled by the
reporter (svn_wc_crawl_revisions), even after we have nested
multi-repository working copy support.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 2 18:13:23 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.