[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: mod_dav/mod_dav_svn PROPFINDS.

From: Kevin Pilch-Bisson <kevin_at_pilch-bisson.net>
Date: 2002-07-01 22:32:31 CEST

On Mon, Jul 01, 2002 at 11:49:49AM -0700, Justin Erenkrantz wrote:
> BTW, I *think* it is related to the fact that the dav_svn_do_walk
> function isn't creating a subpool.
> I'm specifically looking at subversion/mod_dav_svn.c:1963:
> /* fetch this collection's children */
> /* ### shall we worry about filling params->pool? */
> serr = svn_fs_dir_entries(&children, ctx->info.root.root,
> ctx->info.repos_path, params->pool);
> If we had svn blame, we could figure out who added the ### comment
> and I believe whomever said that is right.
> Before calling this function, I think a subpool needs to be
> created and then delete it as we exit this function. This will mean
> that the pool will only grow to the depth of the recursive tree, but
> no more than that rather than the unbounded growth we have now.
> Thanks to Sander who pointed this out to me. I've been trying
> (unsuccessfully) to talk to him wrt to this after he pointed it
> out, so I'll post here in the hopes someone will jump on this.
> I'm not sure I have the time to play with this, but I'm willing to
> guess that this is the problem. -- justin
Unfortunately no. Sander and I tried just such a patch, and it helped, but
did not solve the problem. That is, is reduced memory usage from 700MB to
400, but obviously that is still too high.

Kevin Pilch-Bisson                    http://www.pilch-bisson.net
     "Historically speaking, the presences of wheels in Unix
     has never precluded their reinvention." - Larry Wall

  • application/pgp-signature attachment: stored
Received on Mon Jul 1 22:35:09 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.