Re: SHGetFolderPathA calling shell32.dll (and not shfolder.dll)?

Jostein Christoffer Andersen wrote:

>Hi!
>
>I downloaded the latest Windows zip: svn-win32-r2376.zip, and I can't
>start svn.exe. The system says in message box (translated from Norwegian
>to English):
>
>+--------------------------------------------------------------------+
>| svn.exe - The start address was not found |
>+--------------------------------------------------------------------+
>| The SHGetFolderPathA start address was not found in the library |
>| for dynamuc connections, "SHELL32.dll" |
>+--------------------------------------------------------------------+
>
>I'm not a expert on on C/C++ (I only know the the Windows API from Visual
>Basic, but shouldn't this function be called directly to shfolder.dll
>from config_win.c?
>

Ah, stupid me, I borked the libsvn_subr.dsp. Fixed in revision 2379.

>shfolder.dll do have one more potential problem, it's new as of Windows
>2000 but everyone is free to distribute it so I include it with the next
>version og the Windows Installer
>
>

I strongly suggest *not* including shfolder.dll file in your installer.
Instead, bundle its installer (the URL is in INSTALL), and run it if
you're not on Win2k or newer, so that you don't have to implement all
the extra installation magic.

And ask the user first, and show that URL, so that people can decide to
download and install their own copy directly from Microsoft.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org