Re: Subversion Installer for Windows ready for download

Frohwalt Egerer wrote:

>>Good question.
>>
>>1) Let the user decide. This leaves us with a problem, since we
>> hardcode the path... We need to figure out where diff is located
>> at runtime (registry?).
>>
>>2) Put them in the same path as the svn binaries. We can then determine
>> at runtime where svn was started from, and call diff from the same
>> location.
>>
>>
>
>I'm already underway to writing a patch which does 2). While the patch
>will be simple (GetModuleFileName) this is my first venture into
>SVN's source code ...
>

Don't. Use argv[0] instead, so that the same code can be used on Unix.
In general, we frown upon Windows-specific code in Subversion, except
where absolutely necessary.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org