Re: [PATCH] tools/backup/hot-backup.py

Sander Striker wrote:

>Hi,
>
>Comments on this patch? I'm no python expert, so I'm looking for
>feedback prior to commiting.
>
[snip]

> ######################################################################
>+# Command line arguments
>+
>+
>+if len(sys.argv) != 3:
>+ print "Usage: <repos_path> <backup_path>"
>+ sys.exit(0)
>
Exit with 0 if there's an error? Doesn't seem right.

Also, IMHO should be

    print "Usage:", sys.argv[0], "<repos_path> <backup_path>"

or

    print "Usage:", os.path.basename(sys.argv[0]), "<repos_path>
<backup_path>"

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org