[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Issues 584 & 603 -- / vs. \

From: Martijn Boekhorst <subversion_at_boekhorst.net>
Date: 2002-06-25 23:09:22 CEST

Quoting =?UTF-8?B?QnJhbmtvIMSMaWJlag==?= <brane@xbc.nu>:

> Martijn Boekhorst wrote:
>
> >This is really really really akward to code - and I find myself making
> _alloca
> >macros to get around the issues.
> >
> >Doesn't it make more sense for a win32 version to use the \ path
> convention and
> >perhaps layer/wrap these things with either macros or stubs?
> >
> We already tried handling the different separator styles all through the
> code. It doesn't work out, there were more bugs cause by trying to do
> that than I can count. Ripping that crud out of the libraries was one of
> the best decisions ever made.
>
> >Using MAX_PATH as
> >a constant we can allocate one / thread and use thread local storage
> (related
> >question, are the client libs thread-safe?), then, a macro could be
> included
> >for windows clients to convert these and wrap the original call.
> >
> >Eg. if I may be nasty :
> >#define svn_wc_check_wc(path, is_wc, pool)\
> > svn_wc_check_wc(PATH_LOCAL_TO_SVN(path), is_wc, pool);
> >
> >at the bottom of the file - or better - in a seperate include file
> (keeping the
> >original relatively muck-free), included conditionally at the bottom of
> the svn
> >include file (I don't know - making it up).
> >
> Doesn't make sense. Remember, the libraries offer a _programming_
> interface, so requiring forward slashes there is quite O.K. Especially
> if we provide conversion functions for clients to use, which we will.

Yes, agree completely, but only on programming interface, not the forward
slashes bit. See below.

> >Just thinking out loud here and these are probably silly thoughts, but
> using
> >forward slashes on a win32 platform is really quite 'strange',
> >
> Many programs on Windows accept forward slashes today, and the MS C
> runtime groks them and converts accordingly. So does APR, for that matter.

So shouldn't subversion?

Cheers, Martijn.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 25 23:09:52 2002

This is an archived mail posted to the Subversion Dev mailing list.