[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2330 - trunk trunk/subversion trunk/subversion/include trunk/subversion/libsvn_auth

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-06-25 18:07:36 CEST

"Sander Striker" <striker@apache.org> writes:
> > SVN: ---------------------------------------------------------------------
> > SVN: Enter Log. Lines beginning with 'SVN:' are removed automatically
> > SVN:
> > SVN: Current status of the target files and directories:
> > SVN:
> > SVN: M /home/gstein/src/svn/build.conf
> > SVN: A /home/gstein/src/svn/subversion/include/svn_auth.h
> > SVN: AM /home/gstein/src/svn/subversion/libsvn_auth
> > SVN: A /home/gstein/src/svn/subversion/libsvn_auth/auth.c
>
> Hmmm... :)

Greg, I'm gonna make a guess:

Did you write your log message by having an editor pop up, but then
for some reason aborted the commit, leaving the log message saved in a
file... and then redo the commit later with -F?

Looking at the control flow in svn_cl__get_log_message(), the above
result is exactly what would happen. We only attempt to strip the
prefix if the message was obtained from $EDITOR. If we already have
the message (for example, via -F) then we just return it directly,
with no further processing.

I'm not sure that anything should necessarily be done about this...
though an argument can be made for always stripping the prefix, no
matter what the source of the message. Hmmm.

Thoughts?

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 25 18:15:38 2002

This is an archived mail posted to the Subversion Dev mailing list.