[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2320 - branches/issue-745-dev/subversion/libsvn_fs branches/issue-745-dev/subversion/libsvn_fs/util

From: <cmpilato_at_collab.net>
Date: 2002-06-25 00:02:13 CEST

Greg Stein <gstein@lyra.org> writes:

> On Mon, Jun 24, 2002 at 03:12:03AM -0500, cmpilato@tigris.org wrote:
> >...
> > +++ branches/issue-745-dev/subversion/libsvn_fs/fs.h Mon Jun 24 03:11:57 2002
> > @@ -159,6 +159,10 @@
> > /*** "Delta" Offset/Window Chunk ***/
> > typedef struct
> > {
> > + /* diff format version number ### at this point, "svndiff" is the
> > + only format used. */
> > + apr_byte_t version;
> > +
>
> Are there any packing/alignment issues arising from the insertion of this
> byte (before the apr_size_t)? IOW, we aren't directly memcpy'ing this
> structure into the stream, are we? My concern is alignment and possible
> exceptions caused by that.

Oh, no sir. No direct memcpy's. We should be all good with this.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 25 00:04:09 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.