Re: [PATCH] Generate ISO-8601 dates and canonicalize dates on 'svnadmin dump' - PROBLEM

Greg Stein wrote:
> Actually, this won't happen if you fix one thing, which is currently
> broken today. The svn_log_message_receiver_t type is passing times
> using a string. Instead, it should pass times using apr_time_t, in
> GMT values.

Ah! Exactly! I'll go rumble around the code for that.

> My advice is to apply your patches immediately, but to leave the
> "human" format as what we have today. That will get the *structural*
> changes into the code quickly. Then, when the discussion is settled,
> then you'll only have one piece of code to tweak. This also means
> that your patch won't go stale while the discussion proceeds.

Sounds good, except that I'm going to propose yet another format in
the mean time - and hope it doesn't get any -1's.

-- Naked

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jun 23 10:13:56 2002