Re: svn commit: rev 2308 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_subr trunk/subversion/svnlook trunk/subversion/tests/libsvn_fs trunk/subversion/tests/libsvn_subr trunk/subversion/libsvn_repos

On Sat, Jun 22, 2002 at 03:15:02AM -0500, naked@tigris.org wrote:
>...
> +++ trunk/subversion/include/svn_time.h Sat Jun 22 03:14:47 2002
> @@ -36,7 +36,8 @@
> const char *svn_time_to_nts (apr_time_t when, apr_pool_t *pool);
>
> /* Convert TIMESTR to an apr_time_t. */
> -apr_time_t svn_time_from_nts (const char *timestr);
> +svn_error_t *svn_time_from_nts(apr_time_t *when, const char *data,
> + apr_pool_t *pool);

The comment refers to a param named 'timestr', but you have 'data'.

>...
> +++ trunk/subversion/libsvn_subr/time.c Sat Jun 22 03:14:54 2002
> @@ -110,11 +110,11 @@
>
>
> static int
> -find_matching_string (char *str, const char strings[][4])
> +find_matching_string (char *str, size_t size, const char strings[][4])
> {
> int i;
>
> - for (i = 0; ; i++)
> + for (i = 0; i < size; i++)

We don't use 'size_t', but always 'apr_size_t' or 'int'. In this case,
you're comparing the value against 'i' which is an int, so the parameter
should be an integer.

'str' is not altered in this function, so it should be 'const char *'. (yes,
I know it was like that before, but the point stands :-)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org