[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2218 - trunk/subversion/libsvn_client

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-06-14 21:54:41 CEST

On Fri, Jun 14, 2002 at 02:15:43PM -0500, rooneg@tigris.org wrote:
> Author: rooneg
> Date: 2002-06-14 19:15 GMT
> New Revision: 2218
>
> Modified:
> trunk/subversion/libsvn_client/export.c
> Log:
> * subversion/libsvn_client/export.c
> (remove_admin_dirs, copy_versioned_files): declare key and val as const
> void *'s rather than just void *'s. key has to be const for apr_hash_this,
> and there's no reason for val not to be const, since we never need to
> modify it anyway, so why bother putting it on it's own line ;-)

Look at the definition of apr_hash_this():

APR_DECLARE(void) apr_hash_this(apr_hash_index_t *hi, const void **key,
                                apr_ssize_t *klen, void **val);

That will tell you right away what needs to be const and what doesn't.

-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 14 21:53:13 2002

This is an archived mail posted to the Subversion Dev mailing list.