[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2162 - trunk/subversion/clients/cmdline trunk/subversion/tests/clients/cmdline/getopt_tests_data

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2002-06-12 19:23:42 CEST

On Wed, Jun 12, 2002 at 12:15:00PM -0500, cmpilato@collab.net wrote:
> Garrett Rooney <rooneg@electricjellyfish.net> writes:
>
> > On Wed, Jun 12, 2002 at 05:53:06PM +0100, Philip Martin wrote:
> >
> > > I see, the problem is one of expectation.
> > >
> > > I expected 'svn rollback -r 5 bar' to undo all the changes between
> > > revisions CURRENT and 5. What it does is to undo the change between
> > > revisions 5 and 4.
> >
> > right now, we just revert the actual revision you give us.
>
> While appreciative of the addition of the new subcommand, I dislike
> the current behavior. The notion of a "rollback to a revision X"
> means to restore the state of the file as it was in revision X
> (meaning undoing all changes between X and what is in the working
> copy). To undo a specific revision, one can use `svn diff' and `patch
> -R', or perhaps we could have an `svn undo' subcommand.

i think this may be the best way to go, given the number of people who
assumed the behavior should be that way. if nobody objects, i'll make
this change later today, and possibly have the 'undo' command to do
what 'rollback' is currently doing.

-garrett

-- 
garrett rooney                    Remember, any design flaw you're 
rooneg@electricjellyfish.net      sufficiently snide about becomes  
http://electricjellyfish.net/     a feature.       -- Dan Sugalski
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 12 19:24:16 2002

This is an archived mail posted to the Subversion Dev mailing list.