[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [neon] [PATCH] Fix neon inflate bug

From: Joe Orton <joe_at_manyfish.co.uk>
Date: 2002-06-08 14:48:05 CEST

On Thu, Jun 06, 2002 at 11:20:29AM -0700, Justin Erenkrantz wrote:
> With this patch to neon and HEAD of httpd-2.0 and mod_deflate turned
> on, I can check out my own website under SVN control with gzip
> compression.
>
> So, I think most of the bugs are ironed out now. =)
>
> * src/ne_compress.c (do_inflate): If we have nothing left to inflate,
> do not try to re-execute the loop and inflate again. We would get a
> Z_BUF_ERROR in this case.

Hmmm, I'm not sure it's quite this simple... this only works because
avail_in is guaranteed to be > 0 at the end of the stream because of the
unconsumed gzip trailer.

When does this Z_BUF_ERROR happen - can you send me a document to
reproduce it? zlib.h says that inflate() does either or both of consume
input/provide output, not that it needs to consume input every time it
is called; in my tests inflate() gets called when avail_in is zero
without any problems.

Regards,

joe

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jun 8 14:52:02 2002

This is an archived mail posted to the Subversion Dev mailing list.