[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1887 - trunk/subversion/libsvn_fs trunk/subversion/tests/libsvn_fs

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-06-08 01:44:28 CEST

On Mon, May 06, 2002 at 04:23:26PM -0500, cmpilato@tigris.org wrote:
>...
> +++ trunk/subversion/libsvn_fs/tree.c Mon May 6 16:23:19 2002
>...
> @@ -1271,8 +1273,7 @@
> it doesn't do a brute-force comparison on textual contents, so
> it won't do that here either. Checking to see if the propkey
> atoms are `equal' is enough. */
> - if (! svn_fs__skels_are_equal (SVN_FS__NR_PROP_KEY(tgt_skel),
> - SVN_FS__NR_PROP_KEY(anc_skel)))
> + if (! (tgt_nr->prop_key == anc_nr->prop_key))

This is comparing two pointers, rather than the prop_key values.
Essentially, you want the dag.c's same_keys() function (which also checks
for NULL key pointers).
[ not sure how you want to handle this; move/publicize the function? ]

I found no other bugs or problems with the code (that still exist). I just
checked in (rev 2120) a few minor nits that don't warrant an email.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jun 8 01:43:30 2002

This is an archived mail posted to the Subversion Dev mailing list.