[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2112 - trunk/subversion/libsvn_repos

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2002-06-07 21:53:29 CEST

Greg Stein <gstein@lyra.org> writes:

> On Fri, Jun 07, 2002 at 12:03:35PM -0500, sussman@tigris.org wrote:
> >...
> > +++ trunk/subversion/libsvn_repos/load.c Fri Jun 7 12:03:33 2002
> >...
> > + /* Store name/value in hash. */
> > apr_hash_set (*headers, name, APR_HASH_KEY_STRING, value);
>
> [optimization nit only]
>
> The length of the name == i - 2

Just a sanity check here, correct me if I'm wrong. The rule we're
following is, "if you know the length, use it. otherwise, use
APR_HASH_KEY_STRING." Is that right? I mean, the constant is just
running strlen, right?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 7 21:55:12 2002

This is an archived mail posted to the Subversion Dev mailing list.