Re: [PATCH] Single Character Compile nit on Win32

On Thu, Jun 06, 2002 at 09:53:00AM -0700, Zack Weinberg wrote:
> On Thu, Jun 06, 2002 at 12:30:56PM -0400, Alan Shutko wrote:
> > "Kirby C. Bohling" <kbohling@birddog.com> writes:
> >
> > > So how about -ansi -pedantic -Wno-long-long if that exists for
> > > the 2.95 compiler
> >
> > I've just checked 2.95, and it does have this flag.
>
> Just -pedantic -Wno-long-long will do. You don't want to specify
> -ansi (or -std=anything); it is liable to cause the system headers to
> limit the set of provided declarations, which in turn will cause APR
> to be confused. All the useful standard-compliance warnings (that you
> don't get already with -Wall) come with -pedantic.

Just to point out: Zack is *very* intimate with GCC. I say we take his
advice :-)

However, I just tried this. We've got quite a few warnings that will need to
be cleaned up.

[ oof... there is a problem in ne_utils.h where it defines a variadic macro
  when GCC is present ]

I'll check in some cleanups, but am still unsure about the actual change.
Let's see what gets leftover...

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org