Re: [PATCH] Single Character Compile nit on Win32

Quoting "Jay Freeman (saurik)" <saurik@saurik.com>:

> * subversion/libsvn_client/externals.c (handle_external_item_change):
> VC++ 6
> does not allow a switch with no statements
>
> Index: ./subversion/libsvn_client/externals.c
> ===================================================================
> --- ./subversion/libsvn_client/externals.c
> +++ ./subversion/libsvn_client/externals.c Thu Jun 6 18:48:25
> 2002
> @@ -230,6 +230,7 @@
> case svn_hash_diff_key_a:
> case svn_hash_diff_key_b:
> default:
> + ;
> /* ### in progress */
> }

Hmm, I think this has cropped up before. I wonder if GCC has a warning option
for that ... nope, can't find one. The HP compiler doesn't accept that code,
either. IMHO the standard requires that ';', if I read sections 6.8.1, 6.8.3 and
6.8.4.2 correctly. And sure enough, 'gcc -ansi -pedantic' does warn

I vote we add those options to --enable-maintainer-mode if the compiler is gcc.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 6 16:35:21 2002