[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2074 - trunk/subversion/include trunk/subversion/libsvn_wc

From: Ben Collins-Sussman <sussman_at_red-bean.com>
Date: 2002-06-04 04:41:36 CEST

----- Original Message -----
From: "Greg Stein" <gstein@lyra.org>
To: <dev@subversion.tigris.org>
Sent: Monday, June 03, 2002 8:34 PM
Subject: Re: svn commit: rev 2074 - trunk/subversion/include
trunk/subversion/libsvn_wc

> On Mon, Jun 03, 2002 at 05:41:01PM -0500, kfogel@tigris.org wrote:
> >...
> > Note that this code is not useful until the editor->close_edit() calls
> > have been moved out of the RA layer and into libsvn_client. If anyone
> > has feedback on that, please comment now. My overall plan is to
>
> I don't agree with that change. The RA layer calls replace_root() to start
a
> change, and should call close_edit() to single its termination. The fact
> that something "returns from a func call" should not be the appropriate
> control point.
>
> If the WC and/or client wants to do more work, then empty out your
> close_edit() function and move the work outside of the editor (to be
> performed when RA->do_FOO returns). But do not alter the *usage* of the
> editor to fit your scenario.

Funny, I was about to write the same objection, but gstein beat me to it.
:-)

libsvn_client definitely needs access to any possible svn:externals
properties that the update-editor may have received, but that information
needs to live beyond the edit-baton's life.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 4 17:09:36 2002

This is an archived mail posted to the Subversion Dev mailing list.