[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Re: question for hadaka

From: Nuutti Kotivuori <naked_at_iki.fi>
Date: 2002-05-29 21:09:53 CEST

Karl Fogel wrote:
> Hadaka -- thanks for spotting the dereferencing problem in
> svn_repos_get_committed_info(), fixed now.
>
> I also took a look at set_any_props(), as you mentioned, but didn't
> see any bug there. Did see some unnecessary code, including a
> pointless apr_pstrdup(), which I removed, but no correctness
> problem. Was there something specific you had in mind?

Yes.

-- Naked

Index: ./subversion/libsvn_ra_local/checkout.c
===================================================================
--- ./subversion/libsvn_ra_local/checkout.c
+++ ./subversion/libsvn_ra_local/checkout.c Wed May 29 22:04:58 2002
@@ -91,11 +91,13 @@
     
   apr_hash_set (props, SVN_PROP_ENTRY_COMMITTED_DATE,
                 strlen(SVN_PROP_ENTRY_COMMITTED_DATE),
- svn_string_create (committed_date, pool));
+ committed_date ?
+ svn_string_create (committed_date, pool) : NULL);
     
   apr_hash_set (props, SVN_PROP_ENTRY_LAST_AUTHOR,
                 strlen(SVN_PROP_ENTRY_LAST_AUTHOR),
- svn_string_create (last_author, pool));
+ last_author ?
+ svn_string_create (last_author, pool) : NULL);
   
   
   /* Loop over properties, send them through the editor. */

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jun 1 14:24:05 2002

This is an archived mail posted to the Subversion Dev mailing list.