[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn_dir_make_recursive

From: <cmpilato_at_collab.net>
Date: 2002-05-31 14:53:05 CEST

Greg Stein <gstein@lyra.org> writes:

> On Thu, May 30, 2002 at 10:42:34PM -0700, Justin Erenkrantz wrote:
> > On Fri, May 31, 2002 at 12:40:11AM -0500, B. W. Fitzpatrick wrote:
> > >
> > > OK, I lied. It's not really a patch (and it's not in subversion style,
> > > but I can tweak it easily).
> > >
> > > My question is: where in the hell can I put this?
> > >
> > > I could apr-ize it and put it next to apr_dir_make, but this function
> > > isn't really platform dependent.
> >
> > I'd be game to seeing this in APR. The only problem is that
> > you need any APR way to remove the path components. -- justin
>
> I'd also prefer to see it in APR. Note that we have pure-portable functions
> already in APR (see apr_file_read/write_full()).
>
> Truth to tell, we have a copule functions that would be nice to see in APR.
> Some of them have apr_ prefixes (apr_check_dir_empty and
> apr_hash_sorted_keys). Some others, we've kept as svn_ prefixes, but could
> really go into APR (or one day, create high-level file funcs in apr-util).

Well, I dunno about Greg's "copule" functions (and I don't wanna
know!), but I, too would like to see this apr-ized. And after it is,
Fitz, can you please change `svnlook diff' (I think it's actually
print_diff_tree() in svnlook/main.c) to use it? I seem to recall that
I'm basically doing this very thing in that code.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jun 1 14:12:49 2002

This is an archived mail posted to the Subversion Dev mailing list.