[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Call For Votes: converting log messages to UTF-8

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-05-31 22:40:12 CEST

On Fri, May 31, 2002 at 01:55:33PM -0500, Karl Fogel wrote:
> Colin Putney <cputney@whistler.net> writes:
>...
> > 2) Decree that log messages must be text, and store the metadata
> > specifiying the character set. Have the clients pass the character set
> > to the core libraries and have the libraries return the character set
> > along with the log messages at retrieval time.
>...
> It means passing another parameter along with log_msg itself, but
> that's no big deal.

It is a lot more work than just "one parameter". Each time we find another
"text" item, we're going to have to pass the character set. Every interface
the item passes through will also need to pass the charset. The server will
now have two properties on the revision (svn:log and svn:log-charset).

In the public interface, I count two functions that take a log message
directly, and six functions that take svn_client_get_commit_log_t which has
a log message in it. Within the .c code, I found 53 instances of 'log_msg'.
All of those will need double-params.

Note that some other properties' values will also need to be in UTF-8:
'ignore' and 'externals' (since they store paths, which we already define as
required to be in UTF-8).

But I've always been talking about more than just the log message. Things
like the author, date strings, property names, etc. While author will
generally be simple US-ASCII, I'd prefer to state that it is UTF-8.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jun 1 14:11:03 2002

This is an archived mail posted to the Subversion Dev mailing list.