Re: svn commit: rev 2024 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_subr trunk/subversion/libsvn_ra_local trunk/subversion/libsvn_client trunk/subversion/svnlook trunk/subversion/libsvn_ra_pipe trunk/subversion/clients/cmdline trunk/subversion/tests/libsvn_wc trunk/subversion/tests/libsvn_subr trunk/subversion/tests/clients/cmdline trunk/subversion/tests/libsvn_delta trunk/subversion/libsvn_repos trunk/subversion/libsvn_delta trunk/subversion/libsvn_ra_dav

Thanks for seeing and answering my question, Philip! (Not to mention
the bugfix of 2025).

-K

Philip Martin <philip@codematters.co.uk> writes:
> > + /* ### I do not understand this code. We ascend to some
> > + directory that's not being added, and then set fb->wc_path to
> > + that directory plus this file's entry name! How can that be
> > + right? We're appending this file's name onto some random
> > + directory above it, possibly many levels above it. Someone
> > + hit me over the head with the Clue Stick, please. -kff */
>
> We need to be able to create temporary files associated with this
> file. If the parent directory is added rather than replaced then this
> editor, unlike the update editor, will not have created the new
> directory. If we try to create a temporary file using 'path' it will
> be impossible since there will not be a suitable .svn/tmp/ dir. It is
> possible to create a temporary file using 'wc_path' since that is a
> path into an existing directory.
>
> It's all part of the mess that is temporary file handling. As noted
> in one of the TODOs at the top of the file, it would be better if
> there was some (APR?) interface to provide the equivalent of /tmp or
> TMPDIR. Without such an interface the choice is to assume that either
> the wc or '.' is writeable, this editor chooses to use the wc.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 29 05:13:30 2002