[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: UTF-8

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-05-23 00:54:08 CEST

On Wed, May 22, 2002 at 11:44:38PM +0200, Marcus Comstedt wrote:
>...
> Inside libsvn_*:
>
> All strings are assumed to be UTF-8 encoded

Yup.

> Therefore, all system calls (direct, via APR, or via libc)
> involving strings have to use converted versions of the strings.
> The conversion is placed as close to the system call as possible
> unless there is a compelling argument to do otherwise (arguments
> to non-static svn_*-functions must always be UTF-8 though).

Yup. However, your conversion functions take/return svn_stringbuf_t. Yet the
functions outside of SVN are all 'const char *'. Thus, it makes a *lot* more
sense for your conversion functions to start with the correct type.

[ and yes: the *implementation* might be a stringbuf, but that can be hidden
  from the API ]

Unfortunately, that is going to be a pretty big change for your patch...

I will also recommend that you break the patch into smaller units. For
example, we can add the UTF-8 conversion functions before *any* other code
is changed.

> Inside clients/cmdline:
>...

This all sounds good.

> The current diff (against rev 2000) is included as an attachment. The
> diff for all libs is not yet complete, but those for clients/cmdline
> and libsvn_client are, and may be unmercifully reviewed. :-)

When you attach patches, please ensure their MIME type is text/plain. If
your mailer cannot adjust the mime type after attaching, but merely resides
on a file extension, then just name the patch with '.txt' on the end.

You should also include [PATCH] in the subject line, so that people know
what is in there and can review it.

[ see the "Patch Submission Guidelines" in HACKING. although, I note that it
  doesn't talk about attachments, nor about the dangers of line-wrapping on
  inlined patches ]

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 23 00:51:59 2002

This is an archived mail posted to the Subversion Dev mailing list.