Re: FS tree walking (was: Re: wcprops)

On Mon, May 20, 2002 at 04:22:58PM -0500, Ben Collins-Sussman wrote:
> Greg Stein <gstein@lyra.org> writes:
> > On Mon, May 20, 2002 at 04:00:56PM -0500, Ben Collins-Sussman wrote:
> > >...
> > > uc.resource_walk = TRUE;
> >
> > And let's also not ignore the fact that the above line puts the editor into
> > a different "mode". The editor callbacks now have two potential code paths,
> > based on a giant mode switch set by uc.resource_walk.
> >
> > (i.e. the original editor used to describe the changes to do the switch is
> > now complicated because it has this second code-path wound through it)
>...
> It's not conceptually clean to do such a thing, but it turned out [in
> this particular case] to require almost no change to the editor at
> all. Just lucky.

I just saw your checkin. To me, it looks like a pretty big change to the
editor. There are six separate "if (uc->resource_walk)" tests. To me, that
means that six new alternate code paths have been introduced. While it
happens to "fit in" with the editor, I don't see it as "almost no change".

*shrug*

When the walker function comes around, then we can clean the stuff up.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org