[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: wcprops

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2002-05-20 22:01:58 CEST

Greg Stein <gstein@lyra.org> writes:

> On Mon, May 20, 2002 at 11:36:20AM -0500, Ben Collins-Sussman wrote:
> >...
> > - on the server side, we get a free fs 'walk' from dir_delta by
> > comparing the switched tree against revision 0. dir_delta is
> > driving the xml-output editor in a secondary <resource-walk> mode,
> > which produces a *flat* list of <resource> elements that contain
> > just full paths and vsn-rsc-urls.
>
> The flat list seems fine. I dislike using dir_delta as a mechanism to do a
> walk, though. It smacks too much of "everything is a nail for dir_delta to
> smack."

I guess I'm following svnlook's lead... it passes rev 0 to dir_delta
as a way of printing full trees. Honestly, I've never understood why
we don't use this method in our RA layers for performing checkouts.
Why does each RA layer's do_checkout() have its own implementation of
manually walking an fs tree? Is it *that* much faster than using
dir_delta against rev 0?

I think what's bugging me here is that I don't want to write Yet A
Third Tree Walker for libsvn_fs. Where's the code re-use? I think
what we really want is a single generic fs-tree-walker with callbacks,
that *all* RA layers can use.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 20 22:05:32 2002

This is an archived mail posted to the Subversion Dev mailing list.