[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1973 - trunk trunk/subversion/libsvn_subr

From: Michael Wood <mwood_at_its.uct.ac.za>
Date: 2002-05-17 17:13:42 CEST

On Fri, May 17, 2002 at 12:54:40PM +0100, Philip Martin wrote:
> brane@xbc.nu writes:
>
> > > Modified: trunk/configure.in
> > > ==============================================================================
> > > --- trunk/configure.in (original)
> > > +++ trunk/configure.in Thu May 16 23:52:34 2002
> > > @@ -262,6 +262,19 @@
> > > AC_DEFINE_UNQUOTED(SVN_CLIENT_DIFF3, "$SVN_CLIENT_DIFF3",
> > > [Define to be the full path to your GNU diff3 program])
> > >
> > > +dnl Determine whether diff3 supports the --diff-program arg.
> > > +AC_MSG_CHECKING([whether diff3 supports --diff-program arg])
> > > +touch A
> > > +$SVN_CLIENT_DIFF3 --diff-program=$SVN_CLIENT_DIFF A A A > /dev/null
> > > 2>&1
> > > +if test "$?" = "0"; then
> > > + AC_MSG_RESULT([yes])
> > > + AC_DEFINE_UNQUOTED(SVN_DIFF3_HAS_DIFF_PROGRAM_ARG, 1,
> > > + [Defined if diff3 supports the --diff-program argument])
> > > +else
> > > + AC_MSG_RESULT([no])
> > > +fi
> > > +rm -f A
> >
> > "A" is not a very good choice for a temporary file name (my comments on
> > IRC notwithstanding). I'd either use a file that we know exists (for instance,
> > $abs_srcdir/README) or somehing more obscure, perhaps including the PID.
> > You could even use the name Autoconf generates for test programs.
>
> Put my brain in gear this time...
>
> How about $0? diff3 ${0} ${0} ${0}

How about: diff3 "${0}" "${0}" "${0}"

:)

-- 
Michael Wood <mwood@its.uct.ac.za>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 17 17:15:46 2002

This is an archived mail posted to the Subversion Dev mailing list.