[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1851 - trunk/subversion/include trunk/subversion/libsvn_fs trunk/subversion/tests/libsvn_fs

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-05-15 00:13:53 CEST

On Tue, May 14, 2002 at 02:27:14PM -0500, Karl Fogel wrote:
> Greg Stein <gstein@lyra.org> writes:
> > Ah. Then my next response would be, "drop the cast. constify the structure
> > member."
> >
> > I don't see us changing the *contents* of the ID in the structure. We might
> > point the structure to a new ID, but it would be strange to modify it in
> > place. Thus, the const ought to work fine.
>
> Yeah. Formerly, we needed them non-const because we did modify them
> in place (svn_fs_precede_id(), for example) to do efficient
> decrementing. But that will no longer be necessary.

Actually, I didn't find any places where they were modified in place (using
precede_id, or any other scheme). Revision 1959 constifies the members and
deals with the fallout from that. I also removed the casts :-)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 15 00:12:20 2002

This is an archived mail posted to the Subversion Dev mailing list.