Re: [PATCH] Pre-release version of ISO-8601 dates

Nuutti Kotivuori <naked@iki.fi> writes:
> Here's a pre-release patch of ISO-8601 date conversion for all of
> subversions date needs.

Thanks, this stuff looks great!

Just a small comment:

> + apr_implode_gmt (&when, &exploded_time);
> + }
> + /* Timestamp is something we do not recognize. */
> + else
> + {
> + /* Better zero than something random. */
> + when = 0;
> + }
>
> return when;
> }

The doc string for svn_time_from_nts() in svn_time.h should mention
this behavior (of returning 0 when it can't parse the timestring).

(I haven't reviewed the new regression tests; guests just arrived, so
sending this now :-) ).

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 14 01:43:20 2002