Re: svn commit: rev 1912 - trunk/subversion/include trunk/subversion/libsvn_subr trunk/subversion/libsvn_repos

On Sat, 2002-05-11 at 12:48, Ben Collins-Sussman wrote:
> Well, I'm certain that we want our dumper and loader to operate on
> generic svn_stream_t's. We want maximum flexibility.

Why?

> We certainly *could* write a buffered stream_t, but at the moment, I
> don't think we have a real problem. The stream being read by the
> loader is usually a stdio FILE * anyway, which means the operating
> system is already buffering for us, no?

Sure, there's buffering going on before we hit the actual system call
layer. But for each byte in the dump file, you're performing a function
call (svn_stream_read), a function call through a pointer (the stream's
read function), and another function call (fread), with a certain amount
of extra gook in each. Since dump files are large, I imagine that will
add up to a lot of cycles.

Well, feel free to press on as you are, but if reading dumps is slow,
that would be the first place I'd look.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun May 12 02:28:34 2002