Re: svn commit: rev 1919 - trunk/subversion/clients/cmdline

Karl Fogel <kfogel@newton.ch.collab.net> writes:

> philip@tigris.org writes:
> > if (! editor)
> > return svn_error_create
> > (SVN_ERR_CL_NO_EXTERNAL_EDITOR, 0, NULL, pool,
> > - "Could not find an external text editor in the usual environment "
> > - "variables;\n"
> > - "searched SVN_EDITOR, EDITOR, VISUAL, in that order. If you set\n"
> > - "one of them, check if you also need to `export' it.\n");
> > + "None of the environment variables "
> > + "SVN_EDITOR, VISUAL or EDITOR is set.");
>
> Is there a reason you want this error message to be shorter?
>
> I realize that the bit about exporting the variable is not universally
> applicable, but it kept biting people on the dev list, that's why I
> put it in there...

The fact that it doesn't apply to all shells was the main reason. I
don't use csh if I can avoid it, but it was the company standard at
the last place I worked and export didn't work there.

I won't object if it gets reinstated :)

-- 
Philip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org