Re: svn commit: rev 1923 - trunk/subversion trunk/subversion/libsvn_ra_pipe

On Fri, May 10, 2002 at 09:53:02AM -0400, Mark Benedetto King wrote:
> On Fri, May 10, 2002 at 02:07:36AM -0700, Greg Stein wrote:
>...
> > Per my short review of the existing code, you've got a good chunk more to do
> > than this. ra_pipe is going to need to spawn a subprogram and communicate
> > with it via a pipe so that it can read/write to perform requests. (APR has
> > everything needed to do this)
>
> He only committed it because I asked him to, so that I could add those
> very things. :-)

I was there [on IRC], remember? :-) And if this was already in the plan,
then great! I just didn't know if that problem had been recognized.

>...
> Yes. I was planning on using APR's mechanisms for doing this (exactly
> how apache's mod_cgi works; I'll probably use mod_cgi as a guide). There

Cool. mod_cgi is Goodness, but avoid mod_cgid -- the latter talks to a
persistent daemon which is maintained using the "other child" stuff. That
doesn't apply to what we're doing.

> are two things to know: what program to run locally (rsh/ssh/etc), and
> what arguments to pass it. This second thing is where CVS really falls
> down; it presumes that your program acts exactly like rsh.

Yup.

> For example, something like:
>
> # ~/.subversion/ra_pipe
>
>
> [ra_pipes]
>...

I'd suggest some tweaks to your suggested format, but the general approach
looks good. You might want to consider a way that a person can easily set up
a general pipe description. In CVS land, I just set CVS_RSH=ssh and it all
works fine. I don't have to edit a config file for each and every pipe that
I'll be setting up.

[ I believe that might mean that the pipe: URL syntax would provide for a
  "standard" piping setup ]

>...
> Not that there's no attempt at a rich URL syntax.
> I figure this syntax will be compatible with any
> URL validators that are already in place.
>
> How does this look?

Good, overall. Like I said: if you'd like some real review, then just let us
know! :-)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org