Re: svn commit: rev 1919 - trunk/subversion/clients/cmdline

Justin Erenkrantz <jerenkrantz@apache.org> writes:

> > - "searched SVN_EDITOR, EDITOR, VISUAL, in that order. If you set\n"
> > - "one of them, check if you also need to `export' it.\n");
> > + "None of the environment variables "
> > + "SVN_EDITOR, VISUAL or EDITOR is set.");
>
> s/is/are/

None is singular, at least it is in the UK.

>
> > @@ -408,92 +405,76 @@
> > apr_err = apr_file_write_full (tmp_file, contents->data,
> > contents->len, &written);
> >
> > - /* Close the file. */
> > - apr_file_close (tmp_file);
> > + apr_err2 = apr_file_close (tmp_file);
> > + if (APR_STATUS_IS_SUCCESS(apr_err))
> > + apr_err = apr_err2;
>
> You can just do apr_err == APR_SUCCESS. We've defined APR_SUCCESS
> to always be 0. So, you could even do if (!apr_err). (In fact,
> that's the construct used in the next line.)

So this in apr_errno.h is junk?

#define APR_STATUS_IS_SUCCESS(s) ((s) == APR_SUCCESS \
                || (s) == APR_OS_START_SYSERR + NO_ERROR)

-- 
Philip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org