[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1918 - trunk/subversion/libsvn_repos

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2002-05-10 00:19:13 CEST

Greg Stein <gstein@lyra.org> writes:

> > + remainder = remaining_bytes % buflen;
> > + iterations = remaining_bytes / buflen;
>
> The logic in the function would be a lot simpler if you did a couple things:
>
> * tossed bytes_sucked and just decrement content_length
> * toss remaining_bytes and just test content_length directly
> * don't compute iterations and remainder: just loop, decrement
> content_length for each chunk you read, and exit when content_length
> reaches zero.

Ohhhhhhhhhhhhhhhhhhhh.... of course!

[Ben is flattened by the Clue Anvil]

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 10 00:22:16 2002

This is an archived mail posted to the Subversion Dev mailing list.