[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1915 - trunk/subversion/include trunk/subversion/libsvn_subr trunk/subversion/libsvn_repos

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-05-09 23:18:32 CEST

On Thu, May 09, 2002 at 12:39:10PM -0500, sussman@tigris.org wrote:
>...
> +++ trunk/subversion/libsvn_subr/io.c Thu May 9 12:39:09 2002
>...
> while (1)
> {
> numbytes = 1;
> SVN_ERR (svn_stream_read (stream, &c, &numbytes));
> + if (numbytes != 1)
> + {
> + /* a 'short' read means the stream has run out. */
> + *stringbuf = NULL;
> + return SVN_NO_ERROR;

This means that a file without a trailing newline will throw out the last
line of data. You're returning NULL rather than the data up to EOF.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 9 23:17:20 2002

This is an archived mail posted to the Subversion Dev mailing list.