[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1895 - trunk/subversion/clients/cmdline trunk/subversion/tests/clients/cmdline/svntest

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-05-08 04:46:02 CEST

Philip Martin <philip@codematters.co.uk> writes:
> How can we optimise this? Subversion does a lot by passing filenames
> around. This means that svn_io_check_path() is often called repeatedly
> on the same path, as is svn_wc_entry() or svn_wc_entries_read(). For
> instance each call to svn_wc__timestamps_equal_p() calls
> svn_io_check_path() when assemble_status() has just already done
> so. svn_wc__timestamps_equal_p() also reads the directory entries for
> the file, meaning they get read repeatedly despite having been read in
> svn_wc_statuses().

+1

I think a lot of these are known optimizations; meaning that Ben
Collins-Sussman thought they'd probably be a good idea, but wanted to
wait for profiling information before we bothered to do something more
than the simplest correct code.

Sounds like you just supplied the profiling information. Um. Say,
you wouldn't care to patch too, would you? :-)

Hopefully,
-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 8 04:45:59 2002

This is an archived mail posted to the Subversion Dev mailing list.