[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1890 - trunk trunk/build

From: Branko Čibej <brane_at_xbc.nu>
Date: 2002-05-07 20:16:15 CEST

Greg Stein wrote:

>On Mon, May 06, 2002 at 07:06:49PM -0500, brane@tigris.org wrote:
>
>
>>...
>>+++ trunk/build/buildcheck.sh Mon May 6 19:06:38 2002
>>@@ -2,6 +2,9 @@
>>
>> echo "buildcheck: checking installation..."
>>
>>+# Initialize parameters
>>+NEON_CHECK_CONTROL="$1"
>>+
>> #--------------------------------------------------------------------------
>> # autoconf 2.50 or newer
>> #
>>@@ -56,10 +59,14 @@
>> NEON_WANTED_REGEX=0.19.4
>> NEON_LATEST_WORKING_VER=0.19.4
>> NEON_URL="http://www.webdav.org/neon/neon-${NEON_LATEST_WORKING_VER}.tar.gz"
>>+NEON_TEST_REGEX="$NEON_WANTED_REGEX"
>>+if test "$NEON_CHECK_CONTROL" = "--disable-neon-version-check"; then
>>+ NEON_TEST_REGEX=*
>>+fi
>> if test -d ./neon; then
>> NEON_VERSION="`./ac-helpers/get-neon-ver.sh neon`"
>> case "$NEON_VERSION" in
>>- $NEON_WANTED_REGEX)
>>+ $NEON_TEST_REGEX)
>>
>>
>
>Why a whole new variable here? It would be clearer to just change the
>NEON_WANTED_REGEX variable.
>
>
No reason. That was in the patch, and I didn't feel like changing it.
Want to argue style with me? :-)

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 7 20:17:26 2002

This is an archived mail posted to the Subversion Dev mailing list.