[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Test output.

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2002-04-30 22:08:21 CEST

cmpilato@collab.net writes:

> In diff_tests.py there lies one diff_only_property_change() which,
> when invoked, prints stuff to stdout. This is, in my opinion,
> badness. Is the reason for this function using os.system() because
> we're checking for SEGFAULTness, perhaps?

I believe that was the original problem. However, since the diff
command will produce output if it works and will probably not produce
output if it SEGFAULTs, all we need to do is check that the correct
output occurs.

> I can't think of any other
> reason why we wouldn't be using svntest.main.run_svn() for the "diff"
> portions of this test.
>
> Where's my `svn blame' ?

Not guilty.

-- 
Philip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 30 22:09:19 2002

This is an archived mail posted to the Subversion Dev mailing list.