[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 4 bugs in svn diff (IssueZilla gives me Internal Server Error)

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2002-04-28 03:49:19 CEST

On Sat, Apr 27, 2002 at 08:45:38PM -0500, Eric Gillespie wrote:

> #################################################################
> svn diff dumps core when listing property changes
>
> #0 0x80a3d0a in find_entry (ht=0x0, key=0x810e4d0, klen=12, val=0x0)
> at apr_hash.c:276
> 276 for (hep = &ht->array[hash & ht->max], he = *hep;
> (gdb) bt
> #0 0x80a3d0a in find_entry (ht=0x0, key=0x810e4d0, klen=12, val=0x0)
> at apr_hash.c:276
> #1 0x80a3ea3 in apr_hash_get (ht=0x0, key=0x810e4d0, klen=-1)
> at apr_hash.c:338
> #2 0x8058000 in display_prop_diffs (propchanges=0x812e120,
> original_props=0x0, path=0x810e130 "gnuserv.c", file=0x80d5258,
> pool=0x812e010) at subversion/libsvn_client/diff.c:66
> #3 0x80582e8 in diff_props_changed (path=0x810e130 "gnuserv.c",
> propchanges=0x810e140, original_props=0x0, diff_baton=0xbfbfd370)
> at subversion/libsvn_client/diff.c:212

this seems to be happening because diff_props_changed() is getting
called with original_props = NULL. should diff_props_changed try to
handle this case, or is it just a case of 'svn diff' doing the wrong
thing?

-garrett

-- 
garrett rooney                    Remember, any design flaw you're 
rooneg@electricjellyfish.net      sufficiently snide about becomes  
http://electricjellyfish.net/     a feature.       -- Dan Sugalski
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Apr 28 03:50:11 2002

This is an archived mail posted to the Subversion Dev mailing list.