[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1752 - trunk/subversion trunk/subversion/include trunk/subversion/libsvn_diff

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-04-25 03:42:12 CEST

On Thu, Apr 25, 2002 at 03:20:56AM +0200, Sander Striker wrote:
> > From: Philip Martin [mailto:pm@localhost]On Behalf Of Philip Martin
>...
> > In most (all?) of the existing code static function names do not begin
> > with 'svn_'.
>
> Oh fun... /me must have looked at the wrong file or made a wrong
> assumpting in mind.

The svn_ prefix is *fine* for static functions. Just because the function is
static doesn't mean it won't conflict with things that you #include'd. When
I'm feeling particularly obstinate, I prefix all the static functions. For
example, see mod_dav_svn or mod_dav.

The problem was very much in evidence when people had some local functions
named open() and remove(). Bad bad. Yes, those are obviously ripe for
conflict, but what about close_item() ? Can you be sure?

So... I'd say that you can leave the prefix if you want. Call it a
file-local convention.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 25 03:42:21 2002

This is an archived mail posted to the Subversion Dev mailing list.