[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1757 - trunk/subversion/libsvn_delta

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-04-24 02:28:43 CEST

striker@tigris.org writes:
> Log:
> Namespace protect unexported types. This is
> mostly a s/svn_diff_/svn_diff__/ operation.
>
> Submitted by: Karl Fogel

Cool. Too much credit to me, though; I didn't provide a patch or
anything.

> * subversion/libsvn_delta/diff.c
>
> (svn_diff_lcs_t, svn_diff_node_t,
> svn_diff_position_t, svn_diff_tree_t
> svn_diff_type_e, svn_diff_hat_t):
> Namespace protect.

Just a nit: best to mention both old and new symbol names, if listing
names at all. (But I think for a commit like this, on a relatively
new file, one can just say "Namespace protect a bunch of things." and
leave it at that. :-) ).

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 24 02:26:25 2002

This is an archived mail posted to the Subversion Dev mailing list.