Re: Bug in rev 1623 commit_utils.c:do_item_commit()

cmpilato@collab.net writes:

> Philip Martin <philip@codematters.co.uk> writes:
>
> > Note that display_dir is totally unrelated to item->path. This occurs
> > when I run the command 'svn ci /home/pm/wc' from my build directory
> > /home/pm/sw/subversion/obj. Then in svn_cl__notify_func path is "" but
> > could be almost anything.
> >
> > The problem code is libsvn_client/commit_util.c:752
> >
> > /* Convert an absolute path into a relative one (for feedback.) */
> > const char *path = item->path->data + (display_dir->len + 1);
> >
> > which doesn't make much sense.
>
> Your absolutely right.
>
> Question: What would you *like* to see printed in this case? Absolute
> paths? Relative paths (like ../../wc/foo.c)? Keep in mind that the
> output must be consistent (or at least easily calculable for different
> input data) for scriptability purposes.

Given that I specified an absolute path in the 'svn ci' command I
expect an absolute path in the feedback.

-- 
Philip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org