[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] $EDITOR with spaces

From: Daniel Stenberg <daniel_at_haxx.se>
Date: 2002-04-17 16:17:24 CEST

On 16 Apr 2002 cmpilato@collab.net wrote:

> > i.e. one with a space in the program name as well as in one of the
> > directories. Unfortunately this one deletes my working copy :-(
>
> Here's the deal -- what do we need to do to get functionality consistent
> with other $EDITOR-using programs (like CVS)? Looking at CVS source, it
> just does a strtok() on " \t" to hack a command string into an argslist,
> then has a fork()/execvp() combo. I would imagine this is how most Unix
> programs use $EDITOR, and I guess I don't really feel adventurous enough to
> try to forge new ground in this area.

I vote for requiring spaces to be escaped (possibly with backslashes like
"\ "), otherwise use them as separators. It would make existing
space-for-separator using EDITOR strings to work as before, and new ones
using-space-in-command-name could just learn to follow the escaping.

-- 
      Daniel Stenberg - http://daniel.haxx.se - +46-705-44 31 77
   ech`echo xiun|tr nu oc|sed 'sx\([sx]\)\([xoi]\)xo un\2\1 is xg'`ol
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 17 16:18:40 2002

This is an archived mail posted to the Subversion Dev mailing list.